[Cake] [PATCH] net/sch_generic.h: use sizeof_member() and get rid of unused variable

Antonio Quartulli a at unstable.cc
Wed May 20 17:25:38 EDT 2020

On 20/05/2020 20:17, David Miller wrote:
> From: Antonio Quartulli <a at unstable.cc>
> Date: Wed, 20 May 2020 10:39:33 +0200
>> I don't think it's BUILD_BUG_ON()'s fault, because qcb->data is passed
>> to sizeof() first.
>> My best guess is that gcc is somewhat optimizing the sizeof(gcb->data)
>> and thus leaving the gcb variable unused.
> If you remove the argument from the function but leave the BUILD_BUG_ON()
> calls the same, the compilation will fail.
> Any such optimization is therefore unreasonable.
> The variable is used otherwise compilation would not fail when you
> remove it right?

You're correct.
I guess this should be reported to gcc then.


Antonio Quartulli

More information about the Cake mailing list