[Cake] [PATCH net v2] sched: sch_cake: add bounds checks to host bulk flow fairness counts

[Jakub Kicinski]

On Thu, 09 Jan 2025 17:08:14 +0100 Toke Høiland-Jørgensen wrote:
> >> I guess I should have mentioned in the commit message that this was
> >> deliberate. Since it seems you'll be editing that anyway (cf the above),
> >> how about adding a paragraph like:
> >> 
> >>  As part of this change, the flow quantum calculation is consolidated
> >>  into a helper function, which means that the dithering applied to the
> >>  host load scaling is now applied both in the DRR rotation and when a
> >>  sparse flow's quantum is first initiated. The only user-visible effect
> >>  of this is that the maximum packet size that can be sent while a flow
> >>  stays sparse will now vary with +/- one byte in some cases. This should
> >>  not make a noticeable difference in practice, and thus it's not worth
> >>  complicating the code to preserve the old behaviour.  
> >
> > It's in Jakub's hands now, possibly he could prefer a repost to reduce
> > the maintainer's overhead.  
> 
> Alright, sure, I'll respin :)

Hold on, I'll do it :)