<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>I think we missed an "allocate_host" in cake_hash(), line ~810:</p>
<p>if (allocate_host) {<br>
srchost_idx = srchost_hash % CAKE_QUEUES;<br>
inner_hash = srchost_idx % CAKE_SET_WAYS;<br>
outer_hash = srchost_idx - inner_hash;<br>
for (i = 0, k = inner_hash; i < CAKE_SET_WAYS;<br>
i++, k = (k + 1) % CAKE_SET_WAYS) {<br>
if (q->hosts[outer_hash + k].srchost_tag ==<br>
srchost_hash)<br>
goto found_src;<br>
}<br>
</p>
<br>
<div class="moz-cite-prefix">On 11/25/2017 2:04 PM, Jonathan Morton
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAJq5cE1nfNCfp14WV20-n2988PreiBhsJV+aX5P3fnaX4yxBBg@mail.gmail.com">
<p dir="ltr">Gotos are fairly common in kernel code, chiefly for
exception handling. Obviously structured code is still
preferred where it makes sense, but there are cases where it
would actually confuse matters.</p>
<p dir="ltr">I hope to be able to spend most of tomorrow going
over the code as it currently stands. I even have an up-to-date
net-next tree on one of my machines to build against.</p>
<p dir="ltr"> - Jonathan Morton<br>
</p>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Cake mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Cake@lists.bufferbloat.net">Cake@lists.bufferbloat.net</a>
<a class="moz-txt-link-freetext" href="https://lists.bufferbloat.net/listinfo/cake">https://lists.bufferbloat.net/listinfo/cake</a>
</pre>
</blockquote>
<br>
</body>
</html>