[Codel] [PATCH v6] pkt_sched: codel: Controlled Delay AQM

Eric Dumazet eric.dumazet at gmail.com
Sat May 5 17:58:03 EDT 2012


On Sat, 2012-05-05 at 23:28 +0200, Eric Dumazet wrote:

OK I found the bug

> +		 * if min went above target close to when we last went below it
> +		 * assume that the drop rate that controlled the queue on the
> +		 * last cycle is a good starting point to control it now.
> +		 */
> +		if (ktime_compare(ktime_sub(now, q->drop_next), q->interval16) < 0)
> +			q->count = min(1U, q->count - 1);

	should be : 

			q->count = max(1U, q->count - 1);

> +		else
> +			q->count = 1;
> +		q->drop_next = control_law(q, now);
> +	}






More information about the Codel mailing list