[Codel] [PATCH v9] codel: Controlled Delay AQM

Dave Taht dave.taht at gmail.com
Mon May 7 01:52:18 EDT 2012


On Sun, May 6, 2012 at 10:50 PM, Eric Dumazet <eric.dumazet at gmail.com> wrote:
> On Sun, 2012-05-06 at 22:35 -0700, Dave Täht wrote:
>> This version (9) adds support for various forms of decrease in s3,
>> in the form of the module parameters gentle and decrease_method.
>>
>> It defaults to the algorithm as described in the original presentation.
>>
>> v1: Original implementation - Dave Taht
>> v2: Working code - Corrections for ktime - Dave Taht
>> v3: 32 bit support and port to net-next - Eric Dumazet
>> v4: 16 bit precision for inv sqrt and cache - Dave Taht
>> v5: Kernel cleanup and full precision - Eric Dumazet
>> v6: Dump Stats support added - Eric Dumazet
>> v7: Complete rewrite for u32 values - Eric Dumazet
>> v8: Stats and timing added, 64 bit prescale improved - Eric Dumazet
>> v9: debated functionality moved to isolated routine - Dave Taht
>> ---
>
>> +static u32 gentle = 0;
>> +static u32 decrease_method = 0;
>> +module_param(gentle, uint, 0644);
>> +module_param(decrease_method, uint, 0644);
>> +MODULE_PARM_DESC(gentle,"Gently increment count in massive drop state");
>> +MODULE_PARM_DESC(decrease_method,"Various means of decreasing count");
>
> Hey, thats absolutely forbidden.
>
> Just add new TCA_CODEL_xxx knobs to control things with tc, for each
> qdisc, and not globally on the machine.
>

I regard this addition as a debugging tool, not api functionality, at least
at present...

>
>
> _______________________________________________
> Codel mailing list
> Codel at lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/codel



-- 
Dave Täht
SKYPE: davetaht
US Tel: 1-239-829-5608
http://www.bufferbloat.net



More information about the Codel mailing list