[Codel] [PATCH 1/2] fq_codel: keep dropped statistic around

[Eric Dumazet]

On Oct 21, 2013 6:20 PM, "Dave Taht" <dave.taht at bufferbloat.net> wrote:
>
> Having more accurate dropped information in this qdisc is useful.
>
> Signed-off-by: Dave Taht <dave.taht at bufferbloat.net>
> ---
>  net/sched/sch_fq_codel.c |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c
> index 5578628..437bc95 100644
> --- a/net/sched/sch_fq_codel.c
> +++ b/net/sched/sch_fq_codel.c
> @@ -193,7 +193,6 @@ static int fq_codel_enqueue(struct sk_buff *skb,
struct Qdisc *sch)
>                 list_add_tail(&flow->flowchain, &q->new_flows);
>                 q->new_flow_count++;
>                 flow->deficit = q->quantum;
> -               flow->dropped = 0;
>         }
>         if (++sch->q.qlen <= sch->limit)
>                 return NET_XMIT_SUCCESS;
> --
> 1.7.9.5
I am travelling to Edinburgh, so will be short.

Since fqcodel recycles a slot, we need to clear this counter. We do no know
if slot is reused by previous flow or a new flow hashing to same bucket.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.bufferbloat.net/pipermail/codel/attachments/20131021/50175e69/attachment-0002.html>