[Make-wifi-fast] [PATCH v4] ath9k: Switch to using mac80211 intermediate software queues.

Kalle Valo kvalo at codeaurora.org
Mon Aug 22 11:44:00 EDT 2016

Toke Høiland-Jørgensen <toke at toke.dk> writes:

> This switches ath9k over to using the mac80211 intermediate software
> queueing mechanism for data packets. It removes the queueing inside the
> driver, except for the retry queue, and instead pulls from mac80211 when
> a packet is needed. The retry queue is used to store a packet that was
> pulled but can't be sent immediately.
> The old code path in ath_tx_start that would queue packets has been
> removed completely, as has the qlen limit tunables (since there's no
> longer a queue in the driver to limit).
> Based on Tim's original patch set, but reworked quite thoroughly.
> Cc: Tim Shepard <shep at alum.mit.edu>
> Cc: Felix Fietkau <nbd at nbd.name>
> Signed-off-by: Toke Høiland-Jørgensen <toke at toke.dk>
> ---
> Changes since v3 (most due to Felix; thanks!):
>   - Correctly notify mac80211 when there are packets in the retry queue
>     on powersave start/stop.
>   - Get rid of ath_tx_aggr_resume().
>   - Some readability changes and additional WARN_ON/BUG_ON in
>     appropriate places.

This is great work but due to the regressions I'm not sure if this will
be ready for 4.9. To get more testing time I wonder if we should wait
for 4.10? IMHO applying this in the end of the cycle is too risky and we
should try to maximise the time linux-next by applying this just after
-rc1 is released.


Kalle Valo

More information about the Make-wifi-fast mailing list