[Make-wifi-fast] [RFC] ath9k: Measure per-station airtime usage
toke at toke.dk
Mon May 30 09:27:06 EDT 2016
Michal Kazior <michal.kazior at tieto.com> writes:
>> +void ath_debug_tx_airtime(struct ath_softc *sc,
>> + struct ath_node *an,
>> + struct ath_tx_status *ts)
>> + struct ath_airtime_stats *astats;
>> + rcu_read_lock();
>> + astats = &an->airtime_stats;
>> + astats->tx_airtime += ts->duration;
> I'm not ath9k expert but this seems to be oblivious to tx retries. The
> ts->duration is acquired from the last used tx rate for given frame.
> Or am I missing something?
No, don't think you are. Wasn't sure what exactly that duration field
included, but I think you're right that it doesn't factor in retries.
> I think you should use ts->ts_rateindex and ts->ts_longretry to factor
> in retries (see ath_tx_rc_status).
I'll go digging. Thanks, this was exactly the kind of feedback I had
hoped for! :)
More information about the Make-wifi-fast