[Make-wifi-fast] [PATCH v4] mac80211: Move reorder-sensitive TX handlers to after TXQ dequeue.
toke at toke.dk
Thu Sep 1 04:23:23 EDT 2016
Johannes Berg <johannes at sipsolutions.net> writes:
>> +static int invoke_tx_handlers(struct ieee80211_tx_data *tx)
>> + return invoke_tx_handlers_early(tx) ||
> Ugh, please, no, don't be tricky where it's not necessary. Now every
> person reading this has to first look up the return type, and then the
> return value, and make sure they understand that success is actually
> the value 0 ... that's way too much to ask.
Noted. Any objections to turning these into bool return types?
I'll go through and fix your other comments and send a new version.
Thanks for the feedback :)
More information about the Make-wifi-fast