[Make-wifi-fast] [PATCH v3] mac80211: Dynamically set CoDel parameters per station

[Eric Dumazet]

On Thu, 2017-04-06 at 11:38 +0200, Toke Høiland-Jørgensen wrote:

> +
> +	if (thr && thr < STA_SLOW_THRESHOLD * sta->local->num_sta) {
> +		sta->cparams.target = MS2TIME(50);
> +		sta->cparams.interval = MS2TIME(300);
> +		sta->cparams.ecn = false;
> +	} else {
> +		sta->cparams.target = MS2TIME(20);
> +		sta->cparams.interval = MS2TIME(100);
> +		sta->cparams.ecn = true;
> +	}
> +}

Why ECN is flipped on/off like that ? ECN really should be an admin
choice.

Also, this change in parameters looks suspect to me, adding a bimodal
behavior. I would consult Kathleen and Van on this possibility.