[Make-wifi-fast] [PATCH 1/3] cfg80211: Expose TXQ stats and parameters to userspace

Johannes Berg johannes at sipsolutions.net
Tue May 8 06:19:06 EDT 2018


On Tue, 2018-05-08 at 12:18 +0200, Toke Høiland-Jørgensen wrote:
> Johannes Berg <johannes at sipsolutions.net> writes:
> 
> > net/mac80211/cfg.c:3762:12: warning: context imbalance in
> > 'ieee80211_get_txq_stats' - different lock contexts for basic block
> 
> Found and fixed all the other warnings, but I'm not seeing this one. And
> I don't really see what is wrong with the locking in that function? What
> am I missing?

Oh and what's wrong is that you "return 1" from the function with a lock
held in one place, IIRC.

johannes


More information about the Make-wifi-fast mailing list