[Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

Rajkumar Manoharan rmanohar at codeaurora.org
Tue Oct 2 12:33:27 EDT 2018


On 2018-10-02 01:22, Toke Høiland-Jørgensen wrote:
> Rajkumar Manoharan <rmanohar at codeaurora.org> writes:
> 
>>> Great! I'll fold in the rest, test it with ath9k and submit as a 
>>> proper
>>> patch :)
>>> 
>> Toke,
>> 
>> I noticed a race condition b/w sta cleanup and kick_airtime tasklet.
>> How do you plan to exit kick_airtime gracefully during sta_cleanup?
> 
> Ah, right, there's a lot of stuff going on before we get to purge_txq.
> Hmm, I guess we should either make sure we remove the station from
> active_txqs earlier in the sta cleanup process, or maybe it'd enough to
> just check the removed flag in the tasklet?
> 
> Does the below patch fix the issue?
> 

No. Attaching backtrace. Any clue?

-Rajkumar
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: sta_remove.txt
URL: <https://lists.bufferbloat.net/pipermail/make-wifi-fast/attachments/20181002/200a12d6/attachment.txt>


More information about the Make-wifi-fast mailing list