[Make-wifi-fast] [PATCH RFC v4 3/4] mac80211: Add airtime accounting and scheduling to TXQs

Toke Høiland-Jørgensen toke at toke.dk
Fri Sep 28 03:51:55 EDT 2018



On 28 September 2018 07:29:03 CEST, Rajkumar Manoharan <rmanohar at codeaurora.org> wrote:
>On 2018-09-26 17:09, Rajkumar Manoharan wrote:
>> On 2018-09-26 02:22, Toke Høiland-Jørgensen wrote:
>>> Rajkumar Manoharan <rmanohar at codeaurora.org> writes:
>
>> :( Yeah... I got confused with attached soft lockup in ARM platform.
>> 
>Toke,
>
>Cause for the soft lockup exposed in multi client scenario is due to
>mixed order of fq_lock and active_txqs_lock. In wake_tx_queue or 
>push_pending
>case, driver acquires active_txq_lock first by schedule_start and 
>followed by
>fq_lock in tx_dequeue. The same order should be maintained in sta 
>cleanup.
>Below change fixed the issue.

Ah, great find! I'll fold this into the next version, thanks!

-Toke


More information about the Make-wifi-fast mailing list