<html><head></head><body><div style="color:#000; background-color:#fff; font-family:HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif;font-size:16px"><div id="yui_3_16_0_ym19_1_1483624910716_49042"><span>Hello Dave :</span></div><div id="yui_3_16_0_ym19_1_1483624910716_49150"><span><br></span></div><div id="yui_3_16_0_ym19_1_1483624910716_49067"><span id="yui_3_16_0_ym19_1_1483624910716_49537">Can you please stop cross posting?</span></div><div id="yui_3_16_0_ym19_1_1483624910716_49067"><span><br></span></div><div id="yui_3_16_0_ym19_1_1483624910716_49067"><span id="yui_3_16_0_ym19_1_1483624910716_49268">It's quite annoying to see this unrelated babble about UN-related ath10k when subject is ath9k</span></div><div id="yui_3_16_0_ym19_1_1483624910716_49067"><span><br></span></div><div id="yui_3_16_0_ym19_1_1483624910716_49067"><span id="yui_3_16_0_ym19_1_1483624910716_49536">Felix says it a no go on ath9k airtime fairness for the release....AND that's all we really need to know :)</span></div><div id="yui_3_16_0_ym19_1_1483624910716_49148"><br></div><div id="yui_3_16_0_ym19_1_1483624910716_49148"><br></div><div id="yui_3_16_0_ym19_1_1483624910716_49148">Larry</div> <div class="qtdSeparateBR"><br><br></div><div class="yahoo_quoted" style="display: block;"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div style="font-family: HelveticaNeue, Helvetica Neue, Helvetica, Arial, Lucida Grande, sans-serif; font-size: 16px;"> <div dir="ltr"><font size="2" face="Arial"> On Thursday, January 5, 2017 11:08 PM, Dave Taht <dave.taht@gmail.com> wrote:<br></font></div> <br><br> <div class="y_msg_container">On Thu, Jan 5, 2017 at 6:03 AM, Michal Kazior <<a shape="rect" ymailto="mailto:michal.kazior@tieto.com" href="mailto:michal.kazior@tieto.com">michal.kazior@tieto.com</a>> wrote:<br clear="none">> On 5 January 2017 at 14:23, Felix Fietkau <<a shape="rect" ymailto="mailto:nbd@nbd.name" href="mailto:nbd@nbd.name">nbd@nbd.name</a>> wrote:<br clear="none">>> On 2017-01-05 14:22, Loganaden Velvindron wrote:<br clear="none">>>> On Thu, Jan 5, 2017 at 4:59 PM, Dave Taht <<a shape="rect" ymailto="mailto:dave.taht@gmail.com" href="mailto:dave.taht@gmail.com">dave.taht@gmail.com</a>> wrote:<br clear="none">>>>> Felix:<br clear="none">>>>><br clear="none">>>>> Was there a bugreport? (don't see one)<br clear="none">>>>><br clear="none">>>>> Do you have a specific device or behavior triggering this revert?<br clear="none">>>>><br clear="none">>>>><br clear="none">>>>> On Thu, Jan 5, 2017 at 4:42 AM, Dave Taht <<a shape="rect" ymailto="mailto:dave.taht@gmail.com" href="mailto:dave.taht@gmail.com">dave.taht@gmail.com</a>> wrote:<br clear="none">>>>>> <a shape="rect" href="https://github.com/lede-project/source/commit/c296ba834db4ce8c71e0ad7030aab188fe60b27b" target="_blank">https://github.com/lede-project/source/commit/c296ba834db4ce8c71e0ad7030aab188fe60b27b</a><br clear="none">>>>><br clear="none">>>>><br clear="none">>>><br clear="none">>>> Hi nbd & Toke,<br clear="none">>>><br clear="none">>>> Would it be possible to enable it only on platforms like the tp-link<br clear="none">>>> archer c7 v2 and the ubnt, where we have confirmed test reports for<br clear="none">>>> the upcoming release ?<br clear="none">>> I think it's quite unlikely that these issues are hardware specific.<br clear="none">>> It's probably more related to the environment, types of clients, or even<br clear="none">>> traffic patterns.<br clear="none">><br clear="none">> Some people are complaining ath10k is unstable for them when<br clear="none">> wake_tx_queue is enabled. I suspect the ATF problem in ath9k might be<br clear="none">> providing extra opportunities to hit the same bug.<br clear="none"><br clear="none">Hmm. I would assume most ath10k users are on a multi-core?<br clear="none"><br clear="none">> I think RCU is not properly handled. txq_info shares lifecycle of<br clear="none">> sta_info and should therefore be protected in the same manner. When<br clear="none">> you queue up ieee80211_txq in a driver and use it later you<br clear="none">> effectively break RCU. Grabbing rcu_read_lock() *later*, e.g. when<br clear="none">> re-scheduling tx is not sufficient to protect from the possible race<br clear="none">> of part1/part2 of station destroying logic and driver accessing its<br clear="none">> internal txq list.<br clear="none"><br clear="none">Sounds like a promising theory. Most of our testing was on single-core<br clear="none">devices, with the multi-core x86 version being kernel mainline<br clear="none">(4.8ish), and not the lede backport.<br clear="none"><br clear="none">I long had mildly poor results in terms of throughput on the apu2 (x86<br clear="none">dual core), but assumed it was due to poor antennas. (no crashes)<br clear="none"><br clear="none">The omnia is a dual core arm, but I don't have one of those.<br clear="none"><br clear="none">As it turns out the UAP-lite I flashed ~2 days back is crashed right<br clear="none">now, and another box was failing to get dhcp addresses (why I was<br clear="none">looking at multicast), not even over ethernet.<br clear="none"><br clear="none">(someone remind me to not take a vacation over the holidays, next time<br clear="none">there's holidays)<br clear="none"><br clear="none">> There seems to be a mechanism to hook up with to fix that already -<br clear="none">> drv_sta_pre_rcu_remove().<br clear="none">><br clear="none">> I've been seldom looking at the ath10k problem and noticed this bit. I<br clear="none">> didn't get a chance (and probably won't, any time soon) to take a<br clear="none">> closer look, nor test/verify it for that matter.<br clear="none">><br clear="none">><br clear="none">> Michał<br clear="none"><br clear="none"><br clear="none"><br clear="none">-- <br clear="none">Dave Täht<br clear="none">Let's go make home routers and wifi faster! With better software!<br clear="none"><a shape="rect" href="http://blog.cerowrt.org/" target="_blank">http://blog.cerowrt.org</a><div class="yqt1258260753" id="yqtfd67243"><br clear="none"><br clear="none">_______________________________________________<br clear="none">Lede-dev mailing list<br clear="none"><a shape="rect" ymailto="mailto:Lede-dev@lists.infradead.org" href="mailto:Lede-dev@lists.infradead.org">Lede-dev@lists.infradead.org</a><br clear="none"><a shape="rect" href="http://lists.infradead.org/mailman/listinfo/lede-dev" target="_blank">http://lists.infradead.org/mailman/listinfo/lede-dev</a><br clear="none"></div><br><br></div> </div> </div> </div></div></body></html>