<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple style='word-wrap:break-word'><div class=WordSection1><p class=MsoNormal>Hi dev group guys,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I need to use sysctl to set ms value for net.ipv4.tcp_limit_output_ms .<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>The TSQ patch <b>attached</b> is not working or letting me do that . I am on linux 5.13.12 <o:p></o:p></p><pre><span style='font-family:"Calibri",sans-serif'>Manually changing </span><a href="https://elixir.bootlin.com/linux/latest/C/ident/tx_sk_pacing_shift">tx_sk_pacing_shift</a> = 7; variable in main.c needs to recompile kernel everytime…<o:p></o:p></pre><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I need to have sysctl to control the ms value , to set 2TSQ,4TSQ,8TSQ etc for my wifi chipset.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I will be thankful if anyone can help me in it. <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Rgds,<o:p></o:p></p><p class=MsoNormal>Ahsan<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> 'Neal Cardwell' via BBR Development <bbr-dev@googlegroups.com> <br><b>Sent:</b> Wednesday, November 23, 2022 1:10 AM<br><b>To:</b> Bob McMahon <bob.mcmahon@broadcom.com><br><b>Cc:</b> Dave Taht <dave.taht@gmail.com>; Make-Wifi-fast <make-wifi-fast@lists.bufferbloat.net>; bloat <bloat@lists.bufferbloat.net>; BBR Development <bbr-dev@googlegroups.com><br><b>Subject:</b> Re: [bbr-dev] Aggregating without bloating - hard times for tcp and wifi<o:p></o:p></p></div><p class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Tue, Nov 22, 2022 at 2:43 PM 'Bob McMahon' via BBR Development <<a href="mailto:bbr-dev@googlegroups.com">bbr-dev@googlegroups.com</a>> wrote:<o:p></o:p></p></div><div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><div><div><p class=MsoNormal>Thanks for sharing this. Curious about how the xTSQ value can be set? Can it be done with sysctl?<br><br><i>We continue our analysis by using the ms-version of TSQ patch, which enables the tune of the TSQ size allowing each TCP variant to enqueue more than 1 ms of data at the current TCP rate. In particular, we allow to enqueue the equivalent of x ms of data, naming each test xTSQ, with x being an integer value. <b><span style='color:black;background:yellow'>It is important to notice that this patch has been included in the Linux kernel mainline, and each Wi-Fi driver can now set the desired xTSQ value</span></b></i><b>.</b><o:p></o:p></p></div></div></blockquote><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>I believe they are setting the xTSQ value using the sk_pacing_shift field, which was added here:<o:p></o:p></p></div><div><p class=MsoNormal> <a href="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3a9b76fd0db9f0d426533f96a68a62a58753a51e">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3a9b76fd0db9f0d426533f96a68a62a58753a51e</a><o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>AFAIK the intent is only for drivers to set that, and there's no sysctl for that, but of course you could add a sysctl for testing if you wanted. :-)<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>cheers,<o:p></o:p></p></div><div><p class=MsoNormal>neal<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><div><div><div><p class=MsoNormal>Another thing that could be interesting is the WiFi aggregation stop reasons, e.g. how many times agg stopped per hitting the max mpdu per ampdu vs the software fifo going empty (i.e. no more packets available to the driver from the TCP stack) per that TXOP.<br><br>Finally, many (most?) APs are forwarding and feeding packets at at the hardware level so not sure that the linux stack matters as much for an AP based analysis, particularly when considering multi user transmissions, i.e. multiple WiFi clients are active and sharing TXOPs.<br><br>Bob<o:p></o:p></p></div><div><p class=MsoNormal>On Mon, Nov 21, 2022 at 10:04 PM Dave Taht <<a href="mailto:dave.taht@gmail.com" target="_blank">dave.taht@gmail.com</a>> wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>This paper came out last month. Good work, really exhaustive look at<br>two chipsets, multiple congestion controls and the interactions with<br>TSQ, with<br>lots and lots of flent.<br><br><a href="https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9772053" target="_blank">https://ieeexplore.ieee.org/stamp/stamp.jsp?arnumber=9772053</a><br><br>as for wifi6... don't make me start talking about wifi6... but some of<br>these tests look like a good baseline to start comparing the ath11k,<br>mt79, etc..<br><br>Paper kind of misses the negative impact of AQL in the ath10k (and<br>most likely also the mt76 and mt79 chips)<br><br>-- <br>This song goes out to all the folk that thought Stadia would work:<br><a href="https://www.linkedin.com/posts/dtaht_the-mushroom-song-activity-6981366665607352320-FXtz" target="_blank">https://www.linkedin.com/posts/dtaht_the-mushroom-song-activity-6981366665607352320-FXtz</a><br>Dave Täht CEO, TekLibre, LLC<br><br>-- <br>You received this message because you are subscribed to the Google Groups "BBR Development" group.<br>To unsubscribe from this group and stop receiving emails from it, send an email to <a href="mailto:bbr-dev%2Bunsubscribe@googlegroups.com" target="_blank">bbr-dev+unsubscribe@googlegroups.com</a>.<br>To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/bbr-dev/CAA93jw6yJU10wh9ajqX4yW2AvnJPStyWAAcV4%2BoQ8wSGsJgKZA%40mail.gmail.com" target="_blank">https://groups.google.com/d/msgid/bbr-dev/CAA93jw6yJU10wh9ajqX4yW2AvnJPStyWAAcV4%2BoQ8wSGsJgKZA%40mail.gmail.com</a>.<o:p></o:p></p></blockquote></div></div><p class=MsoNormal><br><span style='font-size:10.0pt;color:black;background:white'>This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.</span> <o:p></o:p></p><p class=MsoNormal>-- <br>You received this message because you are subscribed to the Google Groups "BBR Development" group.<br>To unsubscribe from this group and stop receiving emails from it, send an email to <a href="mailto:bbr-dev+unsubscribe@googlegroups.com" target="_blank">bbr-dev+unsubscribe@googlegroups.com</a>.<br>To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/bbr-dev/CAHb6LvrK_exkt_rbukYkF4_hwPXyy9T%2BZNGzdK79x91RrK49Mg%40mail.gmail.com?utm_medium=email&utm_source=footer" target="_blank">https://groups.google.com/d/msgid/bbr-dev/CAHb6LvrK_exkt_rbukYkF4_hwPXyy9T%2BZNGzdK79x91RrK49Mg%40mail.gmail.com</a>.<o:p></o:p></p></blockquote></div></div><p class=MsoNormal>-- <br>You received this message because you are subscribed to the Google Groups "BBR Development" group.<br>To unsubscribe from this group and stop receiving emails from it, send an email to <a href="mailto:bbr-dev+unsubscribe@googlegroups.com">bbr-dev+unsubscribe@googlegroups.com</a>.<br>To view this discussion on the web visit <a href="https://groups.google.com/d/msgid/bbr-dev/CADVnQyn9OSxPcF2JsUHdiWLTvAAdN5vs1uyiRBL0AS8yH8niYw%40mail.gmail.com?utm_medium=email&utm_source=footer">https://groups.google.com/d/msgid/bbr-dev/CADVnQyn9OSxPcF2JsUHdiWLTvAAdN5vs1uyiRBL0AS8yH8niYw%40mail.gmail.com</a>.<o:p></o:p></p></div></body></html>