From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHRva2UuZGs+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org
Cc: jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net,
zhilinz@nebusec.ai, enjou1224z@gmail.com, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
cake@lists.bufferbloat.net, netdev@vger.kernel.org
Subject: [Cake] Re: [PATCH net] net/sched: sch_cake: drop WARN_ON(1) for malformed packets in ACK filter
Date: Tue, 04 Aug 2026 01:50:06 +0000 [thread overview]
Message-ID: <178580820690.2913307.15981227334988638380.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260729191417.45665-1-toke@toke.dk>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 29 Jul 2026 21:14:16 +0200 you wrote:
> The sch_cake ACK filter parses packets to find the TCP header and filter
> duplicated ACKs if the flow is backlogged. The parsing code contains a
> WARN_ON(1) which can be triggered by a malformed IP header in certain
> cases. Depending on the system configuration, this leads either to
> either spamming dmesg with warnings, or a panic if panic_on_warn is set.
>
> The code already correctly skips the offending packet in the branch that
> triggers the warning, so the WARN_ON itself doesn't really serve any
> purpose. So just drop it altogether to avoid the inconvenient side
> effects.
>
> [...]
Here is the summary with links:
- [net] net/sched: sch_cake: drop WARN_ON(1) for malformed packets in ACK filter
https://git.kernel.org/netdev/net/c/2a33516f9ef5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-08-04 1:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 19:14 [Cake] [PATCH net] net/sched: sch_cake: drop WARN_ON(1) for malformed packets in ACK filter Toke Høiland-Jørgensen
2026-08-04 1:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178580820690.2913307.15981227334988638380.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHRva2UuZGs+?=@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enjou1224z@gmail.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhilinz@nebusec.ai \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox