[Cake] Re: [PATCH net-next v2 1/4] net/sched/sch_cake: serialize reconfiguration with the datapath

[Jamal Hadi Salim <jhs@mojatatu.com>]

On Mon, Oct 19, 2026 at 2:39 PM Toke Høiland-Jørgensen <toke@toke.dk> wrote:
>
> Jamal Hadi Salim <jhs@mojatatu.com> writes:
>
> > On Mon, Oct 19, 2026 at 10:53 AM Björn Töpel <bjorn@kernel.org> wrote:
> >>
> >> Jamal!
> >>
> >> On Mon, 19 Oct 2026 at 15:47, Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> >> >
> >> > Hey Björn,
> >> >
> >> > On Mon, Oct 19, 2026 at 9:07 AM Björn Töpel <bjorn@kernel.org> wrote:
> >> > >
> >> > > Jamal Hadi Salim <jhs@mojatatu.com> writes:
> >> > >
> >> > > > This is a follow-up to commit 7cbfb180945c ("net/sched: sch_cake: fix
> >> > > > autorate reconfiguration throttling").  That change only stored
> >> > > > last_reconfig_time; it did not address the concurrency between the
> >> > > > autorate rate update in cake_enqueue() and the netlink reconfiguration
> >> > > > path, which the original review flagged.
> >> > > >
> >> >
> >> > You are reviewing a very old version - the last one was a v6[1], most
> >> > of these fixes are in the "no good deed goes unpunished" from sashiko
> >> > ;->
> >> > I am about to post a v7. Maybe review that one?
> >>
> >> OMG... sorry for the noise.
> >>
> >
> > Not noise at all - with all these AI dump it is overwhelming. Always
> > great to have someone review. Sashiko will always find something to
> > whine about - the bikeshedding it engages in is shameless sometimes;->
> > I just sent an update.
>
> Erm, I think you're confusing patch series? This one is not the one
> you're at v7 on, Björn did review the latest version AFAICT (and I agree
> with his comments FWIW) :)

Sigh. You are correct - too many patches in flight (in this case both
were 4 patch series and had "cake" in the subject).
Sorry Björn - i will send with your suggestions in place (I notice
that both sashikos have responded and bizare with all their
bikeshedding skills they both missed reverse xmas;->)

cheers,
jamal

> -Toke