Cake - FQ_codel the next generation
 help / color / mirror / Atom feed
From: Eric Dumazet <edumazet@google.com>
To: Samuel Moelius <sam.moelius@trailofbits.com>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"moderated list:CAKE QDISC" <cake@lists.bufferbloat.net>,
	"open list:TC subsystem" <netdev@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: [Cake] Re: [PATCH] net/sched: cake: clamp active flow deficit on rate changes
Date: Mon, 8 Jun 2026 18:08:06 -0700	[thread overview]
Message-ID: <CANn89iKOVOhJz8gPf1hJEcHTxbErVbXF0dAEfrEPjk6X+h2N1A@mail.gmail.com> (raw)
In-Reply-To: <20260609000605.1234374.9ba17536ec9e.cake-rate-change-stale-flow-deficit@trailofbits.com>

On Mon, Jun 8, 2026 at 5:08 PM Samuel Moelius
<sam.moelius@trailofbits.com> wrote:
>
> Changing CAKE rate parameters updates the quantum used for future
> scheduling, but active flows can retain deficit computed under the old
> rate.
>
> That stale deficit lets an already active flow receive service based on
> the previous configuration after userspace changes the shaper rate.
>
> After recomputing rate-derived scheduling parameters, clamp positive
> active-flow deficits to the quantum that applies under the new
> configuration.
>
> Assisted-by: Codex:gpt-5.5-cyber-preview
> Signed-off-by: Samuel Moelius <sam.moelius@trailofbits.com>
> ---

This is bloat for a not existent issue.

pw-bot: cr

  reply	other threads:[~2026-06-09  1:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-09  0:08 [Cake] [PATCH] net/sched: cake: clamp active flow deficit on rate changes Samuel Moelius
2026-06-09  1:08 ` Eric Dumazet [this message]
2026-06-09 12:16   ` [Cake] " Samuel Moelius

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://lists.bufferbloat.net/postorius/lists/cake.lists.bufferbloat.net/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANn89iKOVOhJz8gPf1hJEcHTxbErVbXF0dAEfrEPjk6X+h2N1A@mail.gmail.com \
    --to=edumazet@google.com \
    --cc=cake@lists.bufferbloat.net \
    --cc=davem@davemloft.net \
    --cc=horms@kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sam.moelius@trailofbits.com \
    --cc=toke@toke.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox