[Cake] wash option not in tc-adv

[Kevin Darbyshire-Bryant]

Oh and look for 'wash' in
'openwrt/build_dir/target-*/tc-adv-4.1.0-git/tc/q_cake.c'

e.g.
kevin at Animal
~/git/openwrt/build_dir/target-mips_74kc_musl-1.1.11/tc-adv-4.1.0-git/tc
(kdb) $ grep wash *.c
q_cake.c:                    "                [ wash | nowash* ]\n"
q_cake.c:    int wash = -1;
q_cake.c:        } else if (strcmp(*argv, "nowash") == 0) {
q_cake.c:            wash = 0;
q_cake.c:        } else if (strcmp(*argv, "wash") == 0) {
q_cake.c:            wash = 1;
q_cake.c:            diffserv = 1; /* synonym for besteffort wash*/
q_cake.c:            wash = 1;
q_cake.c:    if (wash != -1)
q_cake.c:        addattr_l(n, 1024, TCA_CAKE_WASH, &wash, sizeof(wash));
q_cake.c:    int wash = 0;
q_cake.c:        wash = rta_getattr_u32(tb[TCA_CAKE_WASH]);
q_cake.c:    if (wash)
q_cake.c:        fprintf(f,"wash ");




On 30/11/15 11:22, Kevin Darbyshire-Bryant wrote:
>
> On 30/11/15 10:22, Vincent Frentzel wrote:
>> Hi Kevin,
>>
>> Thanks for the pointer. 
>>
>> Im 99.9% sure of having done that.
>>
>> 1) I have a cero repo in my feed list.
>> 2) I ran ./scripts/feeds update -a; install -a
>> 3) made oldconfig reviewed the changes (tc-adv and sch-cake are here).
>> 4) ran make dirclean; make
> Looks good to me.  The 'install -a' is not required as 'tc-adv' is
> (hopefully) already installed, and you (equally hopefully) just updated
> it.  To make sure an old version of 'tc-adv' isn't hanging around for
> some reason, 'rm dl/tc-adv-4.1.0-*' is another 'brute force' option.
>> I ll check the Makefile for the version stanza tonight.
> The Makefile is king so worth checking. 
>> I use as option "wash diffserv4". Is this correct? I use this config
>> on my egress queue (facing lan side).
> In fact, as 'diffserv4' is the cake default, you can reduce this to just
> 'wash'.  And I just did 'tc qdisc change dev ifb4eth0 root cake wash
> diffserv4' and it all worked as expected.
>
> You are flashing the box (or uploading the new 'tc-adv' package') right?
> :-)  I know it's a silly question :-)
>> Thanks for your help,
> No problem.
>> BR,
>> Vincent
>>
>> On Mon, Nov 30, 2015 at 11:10 AM Kevin Darbyshire-Bryant
>> <kevin at darbyshire-bryant.me.uk <mailto:kevin at darbyshire-bryant.me.uk>>
>> wrote:
>>
>>     Hi Vincent,
>>
>>     I suspect you've not updated the 'tc-adv' package.  The package
>>     definition contains amongst many things, the revision to checkout from
>>     the git repository containing 'tc-adv'.  If that's not updated,
>>     you get
>>     the old version.  If you run (from your openwrt base directory)
>>     './scripts/feeds update -a' this will update all the packages in all
>>     your configured feeds to their latest versions.  As 'tc-adv' is (or
>>     should be) an already configured package then that should be
>>     sufficient.
>>
>>     I'm guessing you've the 'kmod-sched-cake' and 'tc-adv' packages in a
>>     custom feed, probably something like 'cero'.  Take a look in
>>     'feeds/cero/net/tc-adv/Makefile' and you should find the
>>     PKG_SOURCE_VERSION is 'f789a4897dff988a4d08e39fd360e9468a60fa65'
>>
>>
>>     I hope that helps.
>>
>>     Kevin
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>     On 30/11/15 06:41, Vincent Frentzel wrote:
>>     > Hi Everyone,
>>     >
>>     > Been trying to make use of the wash option the whole week but it
>>     seems
>>     > tc-adv does not accept the param. I cleaned up my build env with
>>     > distclean, started from scratch, no luck. Am I missing something?
>>     >
>>     > Cheers,
>>     > Vincent
>>     >
>>     >
>>     > _______________________________________________
>>     > Cake mailing list
>>     > Cake at lists.bufferbloat.net <mailto:Cake at lists.bufferbloat.net>
>>     > https://lists.bufferbloat.net/listinfo/cake
>>
>>
>>     _______________________________________________
>>     Cake mailing list
>>     Cake at lists.bufferbloat.net <mailto:Cake at lists.bufferbloat.net>
>>     https://lists.bufferbloat.net/listinfo/cake
>>
>
>
>
> _______________________________________________
> Cake mailing list
> Cake at lists.bufferbloat.net
> https://lists.bufferbloat.net/listinfo/cake


-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4816 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://lists.bufferbloat.net/pipermail/cake/attachments/20151130/7366788c/attachment-0002.bin>