[Cake] Patch "sch_cake: avoid possible divide by zero in cake_enqueue()" has been added to the 4.19-stable tree

Dave Taht dave.taht at gmail.com
Sat Jan 11 16:38:27 EST 2020


Thank you for all the gymnastics to keep cake alive in openwrt.

I would still like there to be a sce branch of the out of tree work
that I could point people at
in my lca talk this week, but I understand that's increasingly difficult.

On Sat, Jan 11, 2020 at 1:20 PM Kevin 'ldir' Darbyshire-Bryant
<ldir at darbyshire-bryant.me.uk> wrote:
>
>
>
> > On 11 Jan 2020, at 20:40, Dave Taht <dave.taht at gmail.com> wrote:
> >
> > did this make it into openwrt already?
>
> It’s complicated and it depends what you mean by openwrt.
>
> First off, the fix relates to auto-bandwith mode or whatever it’s called and I don’t think many people use it.  Nonetheless:
>
> Is the fix in ’net-next’: yes
> Is the fix in 4.19 stable: In the queue for 4.19.95
>
> Is openwrt on 4.19.95: No
> Does openwrt use the in-tree version of Cake?: No
>
> Is the fix in the Out-Of-Tree cake git repo: Yes
>
> Has the openwrt CAKE package been bumped to follow cake git repo?: master, yes, as of 2020/01/11 (earlier today)
>
> OpenWrt 19.07 has just been released, its concept of cake package has not been bumped.  Neither has 18.06.
>
>
> It is worth noting that until yesterday/recently the out of tree cake repo had residue in it from some experimental stuff (SCE & updating conntrack marks) and did not represent upstream in-tree CAKE anyway.  That situation was corrected AFAIK completely this morning.
>
> Ideally I would like openwrt to use the in-tree CAKE, with ‘feature backports’ from later kernels as backport patches.  Unfortunately some targets in openwrt are still on 4.14 kernels so there is no in-tree CAKE to use.  Dropping CAKE from pre 4.19 kernels caused a bit of an outcry when I did it, so the next idea was to have a choice of cake kernel module for K4.19 targets, in-tree & out-of-tree CAKE.  Unfortunately that exposed a weakness in package dependency selection, so that idea hasn’t flown either.  I’m afraid enthusiasm levels then dropped.
>
>


-- 
Make Music, Not War

Dave Täht
CTO, TekLibre, LLC
http://www.teklibre.com
Tel: 1-831-435-0729


More information about the Cake mailing list