[Cake] cake's ack-filter vs GSO

[Dave Taht]

My memory about all this stuff is extremely scrambled by the mvneta
driver which ws the first thing that drove me to consider GSO
splitting in the first place.

That evolved significantly. I also remember XMIT_more costing us more
bandwidth than it gained, on the wndr3800, due to eating more cpu or
icache. Then there was the change in how inbound skbs were processed
overall, and innumerable attempts to remove locks from pfifo_fast, and
... ghu knows what else has changed. How does packet pacing affect
things? How much BBRv3 buffers?

I am no longer certain of anything. I am pretty sure, however, that
vikings were not black.

https://gizmodo.com/google-anti-woke-babies-gemini-black-vikings-1851275422

I asked the latest AIs for summaries as to what fq_codel does, what
products it is in, and it was slightly wrong in all cases.

What products have fq_codel in them?" was pretty good.

It just missed apple.

Asking gemini again:

"Is the pie aqm better than fq_codel? How do both compare to CAKE" was also fun.

It generated a really nice table. And made my skin itch at the inaccuracies.

Is the pie aqm better than fq_codel? How do both compare to CAKE?

On Fri, Feb 23, 2024 at 11:39 AM Toke Høiland-Jørgensen <toke at toke.dk> wrote:
>
> Dave Taht <dave.taht at gmail.com> writes:
>
> > On Sun, Feb 18, 2024 at 8:37 AM Toke Høiland-Jørgensen <toke at toke.dk> wrote:
> >>
> >> Dave Taht via Cake <cake at lists.bufferbloat.net> writes:
> >>
> >> > It has been years since I looked at cake's code.
> >> >
> >> > Does anyone remember why we do not ack-filter a gso-split?
> >>
> >> Because a GSO packet cannot be a pure ACK, so it wouldn't be filtered
> >> anyway...
> >
> > But a GRO packet can, and most likely IS a pure ack packet train that
> > could and should be thinned. I think. Yes?
>
> Erm, no, because those would have header differences and so wouldn't be
> combined into a single GRO packet...
>
> -Toke



-- 
https://blog.cerowrt.org/post/2024_predictions/
Dave Täht CSO, LibreQos