[Cake] cake's ack-filter vs GSO

[Toke Høiland-Jørgensen]

Dave Taht <dave.taht at gmail.com> writes:

> On Sun, Feb 18, 2024 at 8:37 AM Toke Høiland-Jørgensen <toke at toke.dk> wrote:
>>
>> Dave Taht via Cake <cake at lists.bufferbloat.net> writes:
>>
>> > It has been years since I looked at cake's code.
>> >
>> > Does anyone remember why we do not ack-filter a gso-split?
>>
>> Because a GSO packet cannot be a pure ACK, so it wouldn't be filtered
>> anyway...
>
> But a GRO packet can, and most likely IS a pure ack packet train that
> could and should be thinned. I think. Yes?

Erm, no, because those would have header differences and so wouldn't be
combined into a single GRO packet...

-Toke