* [Cake] [PATCH net] net/sched: sch_cake: fix autorate reconfiguration throttling
@ 2026-08-16 1:13 Giuseppe Piscitelli
0 siblings, 0 replies; 2+ messages in thread
From: Giuseppe Piscitelli @ 2026-08-16 1:13 UTC (permalink / raw)
To: toke
Cc: jhs, jiri, davem, edumazet, kuba, pabeni, horms, cake, netdev,
linux-kernel
CAKE's autorate-ingress path intends to limit shaper reconfiguration to
once per 250 ms, but last_reconfig_time is only checked and never updated.
Since the field stays zero, every qualifying capacity-estimate window can
call cake_reconfigure(), causing avoidable rate churn and scheduler work
under bursty traffic.
Store the current timestamp when autorate actually reconfigures the qdisc
so the guard enforces the intended interval.
Fixes: 7298de9cd725 ("sch_cake: Add ingress mode")
Cc: stable@vger.kernel.org
Assisted-by: Codex:gpt-5.5
Signed-off-by: ooonea <ooonea@gmail.com>
---
net/sched/sch_cake.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index f25f60978..dc9326702 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -1907,6 +1907,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct
Qdisc *sch,
ktime_add_ms(q->last_reconfig_time,
250))) {
q->config->rate_bps = (q->avg_peak_bandwidth * 15) >> 4;
+ q->last_reconfig_time = now;
cake_reconfigure(sch);
}
}
base-commit: 24ef02f934eeb48830cff6b739abc3c62b1d107b
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cake] [PATCH net] net/sched: sch_cake: fix autorate reconfiguration throttling
@ 2026-08-16 1:21 ooonea
0 siblings, 0 replies; 2+ messages in thread
From: ooonea @ 2026-08-16 1:21 UTC (permalink / raw)
To: Toke Høiland-Jørgensen
Cc: Jamal Hadi Salim, Jiri Pirko, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, cake, netdev,
linux-kernel
CAKE's autorate-ingress path intends to limit shaper reconfiguration to
once per 250 ms, but last_reconfig_time is only checked and never updated.
Since the field stays zero, every qualifying capacity-estimate window can
call cake_reconfigure(), causing avoidable rate churn and scheduler work
under bursty traffic.
Store the current timestamp when autorate actually reconfigures the qdisc
so the guard enforces the intended interval.
Fixes: 7298de9cd725 ("sch_cake: Add ingress mode")
Assisted-by: Codex:gpt-5.5
Signed-off-by: ooonea <ooonea@gmail.com>
---
net/sched/sch_cake.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index f25f60978..dc9326702 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -1907,6 +1907,7 @@ static s32 cake_enqueue(struct sk_buff *skb, struct Qdisc *sch,
ktime_add_ms(q->last_reconfig_time,
250))) {
q->config->rate_bps = (q->avg_peak_bandwidth * 15) >> 4;
+ q->last_reconfig_time = now;
cake_reconfigure(sch);
}
}
base-commit: 24ef02f934eeb48830cff6b739abc3c62b1d107b
--
2.54.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-08-16 1:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-16 1:13 [Cake] [PATCH net] net/sched: sch_cake: fix autorate reconfiguration throttling Giuseppe Piscitelli
-- strict thread matches above, loose matches on Subject: below --
2026-08-16 1:21 ooonea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox